Skip to content

Conversation

@bsieber-mozilla
Copy link
Contributor

No description provided.

@bsieber-mozilla bsieber-mozilla requested a review from a team as a code owner March 24, 2022 05:28
@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 24, 2022 05:28 Inactive
@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 24, 2022 23:36 Inactive
Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few inline comments as a first pass, but looking good so far.

@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 26, 2022 04:13 Inactive
@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 26, 2022 04:23 Inactive
@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 29, 2022 22:14 Inactive
@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 30, 2022 19:50 Inactive
@bsieber-mozilla
Copy link
Contributor Author

Thanks @leplatrem; I've resolved the comments in the most recent commit I believe.

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things that can still be improved I think, if you still have some forces ;)

We've never been so close ;)

@bsieber-mozilla bsieber-mozilla temporarily deployed to dev March 31, 2022 02:26 Inactive
Copy link
Contributor Author

@bsieber-mozilla bsieber-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @leplatrem for your review; I've added some comments--and willing to further adjust, but I think most of the comments have been resolved in the most recent commit.

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

The 202 status is fine yes. What was wondering me most was the catch all of action errors.

The only thing left is the logging. I'm a little bit scared to have requests ignored silently, especially for the first cycles of deployment.

@bsieber-mozilla bsieber-mozilla temporarily deployed to dev April 1, 2022 01:05 Inactive
Copy link
Contributor Author

@bsieber-mozilla bsieber-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leplatrem I went through and made some changes based on your most recent comments.

I tried to add the suggested helper as an injected method in the bugzilla client returned from the get_bugzilla call, but something seemed off with that approach.

@bsieber-mozilla bsieber-mozilla merged commit 289893a into main Apr 1, 2022
@bsieber-mozilla bsieber-mozilla mentioned this pull request Apr 1, 2022
@bsieber-mozilla bsieber-mozilla deleted the def-action branch April 27, 2022 15:36
AshitaSingamsetty pushed a commit to fidelity-contributions/mozilla-jira-bugzilla-integration that referenced this pull request Apr 13, 2023
…iders-issue

Bugfix/terraform providers issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants